Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add OpenAIEmbedder #12

Merged
merged 9 commits into from
Apr 9, 2024
Merged

[Feature] Add OpenAIEmbedder #12

merged 9 commits into from
Apr 9, 2024

Conversation

lsz05
Copy link
Collaborator

@lsz05 lsz05 commented Apr 8, 2024 •
edited
Loading

関連する Issue / PR

#6

PR をマージした後の挙動の変化

OpenAIのembedding modelsが使えるようになりました。

挙動の変更を達成するために行ったこと

OpenAIEmbedderの実装

動作確認

  • テストが通ることを確認した

@lsz05 lsz05 added the enhancement New feature or request label Apr 8, 2024
@lsz05 lsz05 marked this pull request as ready for review April 9, 2024 06:02
@lsz05 lsz05 requested review from ryokan0123 and masaya-ohagi April 9, 2024 06:02
@lsz05 lsz05 force-pushed the feature/openai_api branch from f9dd9ae to b71bd36 Compare April 9, 2024 07:55
masaya-ohagi
masaya-ohagi reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@masaya-ohagi masaya-ohagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしたところ以外はLGTMです！

tests/embedders/test_openai.py Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
ryokan0123
ryokan0123 reviewed Apr 9, 2024
View reviewed changes
src/jmteb/embedders/openai_embedder.py Outdated Show resolved Hide resolved
tests/embedders/test_openai.py Outdated Show resolved Hide resolved
@lsz05 lsz05 requested review from ryokan0123 and masaya-ohagi April 9, 2024 09:19
masaya-ohagi
masaya-ohagi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@masaya-ohagi masaya-ohagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

僕もLGTMです！

@lsz05 lsz05 merged commit 386a1fa into dev Apr 9, 2024
3 checks passed
@lsz05 lsz05 deleted the feature/openai_api branch April 10, 2024 02:20
@lsz05 lsz05 mentioned this pull request Apr 11, 2024
Closed
@lsz05 lsz05 mentioned this pull request Apr 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaya-ohagi masaya-ohagi masaya-ohagi approved these changes

@ryokan0123 ryokan0123 ryokan0123 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsz05 @ryokan0123 @masaya-ohagi